BIND 10 #2102: type of test is bool

[BIND 10 Development]

#2102: type of test is bool
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:
  fdupont                            |                Status:  new
                       Type:         |             Milestone:  New Tasks
  enhancement                        |            Resolution:
                   Priority:  low    |             Sensitive:  0
                  Component:         |           Sub-Project:  Core
  Unclassified                       |  Estimated Difficulty:  0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by fdupont):

 Replying to [comment:1 jinmei]:
 > Replying to [ticket:2102 fdupont]:
 > > An example is the ASSERT_TRUE()s in src/lib/acl/tests/loader_test.cc
 which are against pointers (so ASSERT_TRUE(foo) -> ASSERT_TRUE(foo !=
 NULL))
 >
 > (just a comment) It's also against part of our coding guideline
 > derived from that of BIND 9.  I normally point them out when find them
 > in code review, but of course such human efforts cannot be
 > comprehensive.

 => the WIN32 port can get more (for instance a "int found1 = false;"...).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2102#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development