BIND 10 #2062: bind10-showtech initial version
BIND 10 Development
do-not-reply at isc.org
Sat Jun 30 16:37:54 UTC 2012
#2062: bind10-showtech initial version
-------------------------------------+-------------------------------------
Reporter: shane | Owner: muks
Type: task | Status: reviewing
Priority: | Milestone:
medium | Sprint-20120703
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Sub-Project: Core
Defect Severity: N/A | Estimated Difficulty: 5
Feature Depending on Ticket: | Total Hours: 0
bind10-showtech |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => muks
Comment:
Hello
I have several comments.
First, I'd modify the changelog slightly. It looks like Bind10 has a
support staff. Maybe say future support staff?
'''Regarding functionality'''
I'm not sure what if anything of this is in scope of this ticket, but I
want to note it down.
I'd like an option to put the output to a file. The output is really long
and scrolls through the screen. Also, once we include things like
config.log, our log files and our configuration, it could be handy to have
them as separate files and pack them together with tar or something.
While I agree it is good to have network information, routing info, list
of open connections with process names and list of processes (as suggested
on the wiki page), these information may be considered sensitive by some
admins and they would not like to share them. Unless we provide some kind
of switch, like `--no-sensitive`, it could lead to them not providing the
output of `b10-showtech` at all.
There's no `--help` option.
If the script is run as non-root (which is reasonable to assume it will),
it silently says the network information is Unknown. It would be nice to
detect the situation and warn about it (preferably at the end of the
output, so it does not scroll far away and the user sees).
'''Technical problems'''
A test fails:
{{{
======================================================================
FAIL: test_calls (__main__.TestRename)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/vorner/work/bind10/bind10-devel-20120405/_build/src/bin/tests/process_rename_test.py",
line 62, in test_calls
self.__scan(d, script, fun)
File
"/home/vorner/work/bind10/bind10-devel-20120405/_build/src/bin/tests/process_rename_test.py",
line 32, in __scan
"Didn't find a call to isc.util.process.rename in " + prettyname)
AssertionError: None is not true : Didn't find a call to
isc.util.process.rename in src/src/bin/showtech/b10-showtech
----------------------------------------------------------------------
}}}
Should the generated man page be in git?
I don't think the current tests are good enough. They test only little bit
of the code that is just setting of some default values. Everything should
be tested, if only on Linux or by replacing the system calls with some
mock functions.
A lot of the calls are not system specific. For example, according to
python documentation, os.uname() should be available on most Unix systems.
So it would be nice to put it into some try-catch block to the base class
so other OSes (or the unknown ones) don't need to reimplement it again and
again. Other things might be also available more generally than on linux
only. The derived ones can always override the detection if it does not
work for the system.
--
Ticket URL: <http://bind10.isc.org/ticket/2062#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list