BIND 10 #1602: Introduce dns::LabelSequence class

BIND 10 Development do-not-reply at isc.org
Thu Mar 1 11:25:39 UTC 2012


#1602: Introduce dns::LabelSequence class
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20120306
                  Component:         |            Resolution:
  libdns++                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  7
Feature Depending on Ticket:  auth   |           Total Hours:  1.52
  performance                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte
 * totalhours:  0 => 1.52


Comment:

 Hello

 Generally, looks good.

 Replying to [comment:12 jelte]:
 > ok, split up split into split and split, er, leftSplit() and
 rightSplit()

 Thanks.

 But looking at it again, I don't know if the name „split“ is the best one.
 Maybe it's just too much perl and haskell experience, but I'd expect split
 to return multiple things (in perl, you split string by some delimiter and
 it returns an array of all the parts in between) or the part before and
 after the splitpoint (haskell).

 So, on one side, names like `removeFront` and `removeBack` or
 `removeFromLeft` and `removeFromRight` could be better. On the other side,
 the Name has a split method which is similar to what this does (but in
 case of Name, it should be called subName, or something). So, I don't
 really care much about it and I'll leave it up to you.

 So, the branch is ready for merge, with or without the name change, as you
 prefer.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1602#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list