BIND 10 #1612: b10-auth should catch exceptions in response building

[BIND 10 Development]

#1612: b10-auth should catch exceptions in response building
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120306
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  3
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Replying to [comment:8 vorner]:
 > Hello
 >
 > I have few comments.
 >
 > First, should there be a changelog entry? This could change an external
 behaviour.
 >

 Oh yes,

 [defect]
 b10-auth now catches any exceptions during response building; if any
 datasource either throwa an exception or causes an exception to be thrown,
 the message processing code will now catch it, log a debug message, and
 return a SERVFAIL response.

 > '''Style issues'''
 >


 all three fixed

 > How deep recursion do we allow in tests? ;-)
 > {{{
 > // Test for the tests
 > }}}
 >

 :)

 > Maybe the `ThrowWhen` members should be all in capitals?
 >

 oh duh, of course

 > '''Code brevity vs. repetititiveness'''
 > There's a bunch of tests with really similar body:
 >
 > (and one test type in many instances as well). Would it be possible to
 make it shorter by using a for cycle over the places where it should fail,
 something like:
 >


 Yes, but it did require a slight fix in AuthSrvTest::processMessage(). By
 using the nsec3 dnssec query, i was also able to roll all of them except
 one into one loop.

 > '''Correctness'''
 > The lettuce tests fail for me.
 >

 This seemed unrelated and has been redirected to another ticket (#1757)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1612#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development