BIND 10 #1640: incomplete pc file for botan and wrong filename for botan-config

[BIND 10 Development]

#1640: incomplete pc file for botan and wrong filename for botan-config
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  UnAssigned
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  minor  |  Sprint-20120306
                  Component:  build  |            Resolution:
  system                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  Core
            Defect Severity:  N/A    |  Estimated Difficulty:  4
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 The ticket was mostly waiting on someone to make a final decision on what
 to do with this :)

 So I decided to replace --with-botan with --with-botan-config, which takes
 the full path to the config script (no ${val}/bin/scriptname guessing if
 this value is provided). In case it is not provided, and pkgconfig does
 not appear to know about botan, it will loop over a number of possible
 botan-config scripts (from botan-config-1.10 down to botan-config-1.8 and
 finally plainly botan-config).

 I also expanded the compile/link test error with a message about if it
 fails, but botan is installed, it may be the case that there are missing
 dependencies and installing libbz2 and libgmp might help (which would
 'solve' #1201, as far as i think we should solve it).

 WARNING FOR REVIEWER: BRANCH IS CALLED trac1640_2

 So this is ready for review. I had not realized Jeremy put in a branch
 yet, and since mine is based on a newer branch of master, I decided not to
 expand on his branch but create a new one called trac1640_2

 WARNING FOR REVIEWER: BRANCH IS CALLED trac1640_2

 Suggested changelog:

 [build]* jelte
 The configure option for botan (--with-botan=PATH) is replaced by --with-
 botan-config=PATH, which takes a full path to a botan-config script,
 instead of the botan 'install' directory. Also, if not provided, and pkg-
 config does not know about botan, it tries several possible names instead
 of just botan-config.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1640#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development