BIND 10 #1280: suggestion: record xfrin-session-statistics and log it

[BIND 10 Development]

#1280: suggestion: record xfrin-session-statistics and log it
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120320
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  statistics                         |  Estimated Difficulty:  3
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:  AXFR-  |
  in                                 |
        Add Hours to Ticket:         |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Replying to [comment:15 vorner]:
 >  * Changelog?

 oh right, of course
 [func] jelte
 The b10-xfrin module now logs more information on successful incoming
 transfers. In the case of IXFR, it logs the number of changesets, and the
 total number of added and deleted resource records. For AXFR (or AXFR-
 style IXFR), it logs the number of resource records. In both cases, the
 number of overhead DNS messages, runtime, amount of wire data, and
 transfer speed are logged.

 >  * The system tests fail.
 > {{{
 > Exit from bindctl
 > I:nsx2 waiting for SOA serial to change from 94
 > I:nsx2 SOA serial was at 94, now at 100
 > I:client and server zones identical
 > R:nsx2 FAIL no 'IXFR successful' message in the BIND 10 log
 > R:FAIL
 > E:ixfr/in-2:Thu Mar  8 14:38:02 CET 2012
 > make: *** [systest] Error 1
 > }}}

 Oh right i changed the message :) Fixed

 >  * If there's an AXFR-like IXFR, which message of the two will be
 printed?
 >

 Hmm, good point, the IXFR message is useless then, but an AXFR-specific
 message might be confusing or missed; I've reverted the AXFR message to be
 type-agnostic (with the transfer type as a log call argument); so now
 it'll print 'XFRIN_TRANSFER_SUCCESS full IXFR transfer ...'
 'XFRIN_TRANSFER_SUCCESS full AXFR transfer ...', and call that one based
 on what was counters in the stats object

 > Also, maybe create the ticket for showing as a bindctl command?

 done, #1770

-- 
Ticket URL: <http://bind10.isc.org/ticket/1280#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development