BIND 10 #1698: log initialization causes real fiasco for MacOS 10.7

[BIND 10 Development]

#1698: log initialization causes real fiasco for MacOS 10.7
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120320
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  Core
  logging                            |  Estimated Difficulty:  5
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:11 stephen]:

 The branch now looks almost okay for merge.

 I've fixed a few minor points directly in the branch, and have some
 more additional comments (below).  I don't think we need another
 review cycle for them, so after addressing these please feel free to
 merge.


 > > Maybe "Mac OS (X) 10.7" instead of just "OS X"?
 > I'll use "Mac OS X" (as used in the Wikipedia entry) as I don't think
 any literature places the "X" in brackets.

 By using parentheses I meant "either 'Mac OS 10.7' or 'Mac OS X
 10.7'.

 Other comments:

 - the newly created test .cc files (e.g.
 message_initializer_1_unittest.cc)
   - the Copyright year should be 2012?
   - we should probably order the header files as we agreed before
     (internal first, standard last)
 - message_initializer.h, getPendingCount(): "the message of message
   arrays" doesn't seem to be correct.  You meant "the array of message
   arrays" or something?
 {{{#!c++
     /// Returns a count of the message of message arrays that have been
     /// registered with this class and will be loaded with the next call
     /// to loadDictionary().
 }}}
 - tests/Makefile.am: I think we normally use AM_CPPFLAGS, etc for
   things like COMMON_CPPFLAGS, etc.  (But I don't insist).
 - about death tests: it may not be available for all buildbots. I see
   some existing death tests were ifdef'ed out.  we should probably do
   the same.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1698#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development