BIND 10 #860: sqlite3 data source should separate DONE and other errors

[BIND 10 Development]

#860: sqlite3 data source should separate DONE and other errors
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  assigned
                       Type:  task   |             Milestone:
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  data   |           Sub-Project:  DNS
  source                             |  Estimated Difficulty:  0.0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:2 shane]:
 > Jinmei, I don't see this construct in the sqlite3_accessor.{cc,h} files.
 I assume this means the re-implementation does not use this approach. Can
 we resolve this ticket?

 We should probably check return value handling sqlite3_accessor, too.
 From a quick look I'm afraid this may not be (entirely) correct:

 {{{#!c++
     if (sqlite3_step(prepared) != SQLITE_ROW) {
         isc_throw(SQLite3Error,
                     "Unable to query version: " << sqlite3_errmsg(db));
     }
 }}}
 (consider the case, e.g. where the schema_version table is empty)

 I also wonder whether it's okay not to separate DONE and other error
 code in getRecordDiff().

-- 
Ticket URL: <http://bind10.isc.org/ticket/860#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development