BIND 10 #1748: define AbstractRRset::isSameKind() and implement the default version

BIND 10 Development do-not-reply at isc.org
Tue Mar 13 04:02:25 UTC 2012


#1748: define AbstractRRset::isSameKind() and implement the default version
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  high   |  Sprint-20120320
                  Component:         |            Resolution:
  libdns++                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:  auth   |           Total Hours:  0
  performance                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by muks):

 Replying to [comment:10 jinmei]:
 > I'd compare the types first, because comparing names is more
 > expensive.  I think comparing the classes last makes sense.  I'd also
 > make an explicit comment about why we compare these in that specific
 > order.

 The original code compared type, class and name in that order. I still
 think that's the proper order as the class comparison is O(1) and name
 should come last. But I've changed the code and put in the comment for
 type, name, class in that order.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1748#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list