BIND 10 #1751: stats doesn't separate or consolidate reports from multiple auth instances

[BIND 10 Development]

#1751: stats doesn't separate or consolidate reports from multiple auth instances
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120320
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  Core
  statistics                         |  Estimated Difficulty:  6
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => UnAssigned
 * status:  assigned => reviewing


Comment:

 The branch trac1751 is ready for reviewing. But I think this is a
 temporary fix for this defect.

 A pid argument is newly introduced in the set command of stats. It's used
 by stats to identify which instance sends statistics data. I'm not sure
 whether the statistics management by pid is ok or not for this purpose.

 For a multi-instance module like auth, the process id should be set in the
 argument. However for a single-instance module like boss, the pid doesn't
 have to be set. In this case the default value -1 is assumed.

 In addition of the variable of statistics data of each module which exists
 before, stats internally has the variable of statistics data of each pid.
 When stats receives new statistics data, it internally updates statistics
 data of each pid and updates statistics data of each module by
 accumulating statistics data of each pid.

 Even if the sender instance has already died, stats preserves statistics
 data which it had before, and accumulates it. But if the pid on the system
 rotates and same number is assigned again to one of the multiple
 instances, statistics data of the instance might be reset.

 The views in bindctl and HTTP/XML aren't changed at all in that branch.
 But in another ticket they would be more changed so that administrators
 can see statistics by each instance.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1751#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development