BIND 10 #1568: Change throw to assert to gain performance

[BIND 10 Development]

#1568: Change throw to assert to gain performance
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120320
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  b10-auth                           |  Estimated Difficulty:  0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
  performance                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 nFYI: I'm pasting my result

 Focusing on the new renderer implementation, the assert version
 is 7.3%, 9.2%, 1.0% faster than the method version (for positive,
 NXDOMAIN, SERVFAIL cases respectively).

 1568_new
 {{{
 Parameters:
   Iterations: 100000
 Benchmark for old MessageRenderer (positive response)
 Performed 4200000 iterations in 6.840785s (613964.63ips)
 Benchmark for dumb MessageRenderer (positive response)
 Performed 4200000 iterations in 0.166941s (25158588.96ips)
 Benchmark for new MessageRenderer (positive response)
 Performed 4200000 iterations in 1.085116s (3870553.93ips)
 Benchmark for old MessageRenderer (NXDOMAIN response)
 Performed 400000 iterations in 0.496187s (806147.68ips)
 Benchmark for dumb MessageRenderer (NXDOMAIN response)
 Performed 400000 iterations in 0.016813s (23791114.02ips)
 Benchmark for new MessageRenderer (NXDOMAIN response)
 Performed 400000 iterations in 0.149617s (2673492.99ips)
 Benchmark for old MessageRenderer (SERVFAIL response)
 Performed 100000 iterations in 0.065764s (1520588.77ips)
 Benchmark for dumb MessageRenderer (SERVFAIL response)
 Performed 100000 iterations in 0.004095s (24420024.42ips)
 Benchmark for new MessageRenderer (SERVFAIL response)
 Performed 100000 iterations in 0.052844s (1892362.43ips)
 }}}

 1568_method
 {{{
 Parameters:
   Iterations: 100000
 Benchmark for old MessageRenderer (positive response)
 Performed 4200000 iterations in 7.061764s (594752.25ips)
 Benchmark for dumb MessageRenderer (positive response)
 Performed 4200000 iterations in 0.175361s (23950593.35ips)
 Benchmark for new MessageRenderer (positive response)
 Performed 4200000 iterations in 1.164642s (3606258.40ips)
 Benchmark for old MessageRenderer (NXDOMAIN response)
 Performed 400000 iterations in 0.485412s (824042.26ips)
 Benchmark for dumb MessageRenderer (NXDOMAIN response)
 Performed 400000 iterations in 0.016988s (23546032.49ips)
 Benchmark for new MessageRenderer (NXDOMAIN response)
 Performed 400000 iterations in 0.163406s (2447890.53ips)
 Benchmark for old MessageRenderer (SERVFAIL response)
 Performed 100000 iterations in 0.068464s (1460621.64ips)
 Benchmark for dumb MessageRenderer (SERVFAIL response)
 Performed 100000 iterations in 0.004166s (24003840.61ips)
 Benchmark for new MessageRenderer (SERVFAIL response)
 Performed 100000 iterations in 0.053355s (1874238.59ips)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1568#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development