BIND 10 #1750: add "at origin" option in ZoneFinder::find() and support it in in-memory

BIND 10 Development do-not-reply at isc.org
Tue Mar 13 09:53:40 UTC 2012


#1750: add "at origin" option in ZoneFinder::find() and support it in in-memory
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  high   |  Sprint-20120320
                  Component:  data   |            Resolution:
  source                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  4
Feature Depending on Ticket:  auth   |           Total Hours:  0
  performance                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Replying to [comment:9 jinmei]:
 > Sorry for introducing but one thing: before merging please confirm
 > whether it actually improves performance and how much.  While it was
 > myself who suggested optimization, I also think we should be careful
 > not introducing too marginal optimizations and making the code more
 > complicated.

 Ah, right, so I compared it with query_bench against the place I branched
 (so the difference is fair, not agains some other optimisation we included
 in the meantime). And the difference is rather small:

 With the change:
 {{{
 Benchmark with In Memory Data Source
 Processed 4000000 queries in 52.754674s (75822.67qps)
 }}}

 And without:
 {{{
 Benchmark with In Memory Data Source
 Processed 4000000 queries in 53.023560s (75438.16qps)
 }}}

 I think it is not worth it. Do you agree we should drop the branch, then?

-- 
Ticket URL: <http://bind10.isc.org/ticket/1750#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list