BIND 10 #1751: stats doesn't separate or consolidate reports from multiple auth instances

[BIND 10 Development]

#1751: stats doesn't separate or consolidate reports from multiple auth instances
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  naokikambe
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120320
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  Core
  statistics                         |  Estimated Difficulty:  6
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => naokikambe


Comment:

 Hello

 Replying to [comment:8 naokikambe]:
 > The branch trac1751 is ready for reviewing. But I think this is a
 temporary fix for this defect.

 Yes, I agree with this ‒ I think it is better than not having it, but it
 still needs more tweaking. I'm especially worried about one thing ‒ now a
 module that has multiple instances preserves them across restarts, while
 the others don't. This acts in an inconsistent way. Would you create a
 ticket for it?

 As for the thing with PIDs, we probably want to solve it in a more wide
 way, together with addressing multiple instances in commands, etc. So
 that'll probably provide further insight on how this should be handled in
 the long term.

 About the code, first I'd like to note that resolver also supports
 multiple instances. Would you add the support to it as well?

 The tests of stats, I think `EXPECT_GT` would be better here:
 {{{#!c++
     EXPECT_TRUE(statistics_session_.sent_msg->get("command")
                 ->get(1)->get("pid")->intValue() > 0);
 }}}

 What do the two stars mean here?
 {{{#!python
 **{'queries.tcp':1001}
 }}}

 I think you mean `set Boss/components/b10-auth-2` here:
 {{{
 echo 'config add Boss/components b10-auth-2
 config set Boss/components/b10-auth { "special": "auth", "kind": "needed"
 }
 }}}

 Also, would you provide a changelog entry? I think one would be needed,
 since it fixes a visible problem.

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/1751#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development