BIND 10 #1600: Use UDPSyncServer for b10-auth

[BIND 10 Development]

#1600: Use UDPSyncServer for b10-auth
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  kevin_tes
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120320
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  auth   |
  performance                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by kevin_tes):

 Replying to [comment:24 jinmei]:
 > Replying to [comment:23 jinmei]:
 > > Replying to [comment:22 muks]:
 > >
 > > > > Regarding the code, it's not exception safe: If message->toWire()
 > > > > throws in the middle of it, renderer_ will keep remembering the
 > > > > previously set buffer.  In the version of the base for trac1600 it
 > > > > doesn't matter much because the process will immediately die
 anyway.
 > > > > But the latest code catch the condition and continue to the next
 > > > > message.  So once this branch is merged this bug becomes more
 > > > > critical.
 > > >
 > > > kevin_tes: Was MessageRendererHandle introduced to address this
 issue?
 > >
 > > I suspect so, but if so, it doesn't seem to address my points (btw,
 > > messagerendererhandle.h has many style issues).
 >
 > On thinking about it further, I have a revised proposal if I may:
 >
 > - revert ede52d8, and
 > - just clear the renderer_ before using it
 >
 > That's a suboptimal solution, but should be the smallest solution for
 > now.  We are going to defer the similar cleanup for #1717 to a
 > separate ticket anyway, so we could do the clean up for the renderer
 > stuff there, too.
 >
 > At this stage I think it makes more sense to complete this task and
 > merge the feature sooner.

 The suggestion makes sense. I'll do that.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1600#comment:25>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development