BIND 10 #1321: Allow sending notify manually

[BIND 10 Development]

#1321: Allow sending notify manually
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120320
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  xfrout                             |  Estimated Difficulty:  4
                   Keywords:         |           Total Hours:  2
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jelte):

 Replying to [comment:8 muks]:
 > Hi jelte
 >
 > {{{
 > +        { "command_name": "notify",
 > }}}
 >
 > I guess it's not possible to use notify_out.ZONE_NEW_DATA_READY_CMD
 there? (Is the .spec file evaluated as Python code, or read as a JSON
 file?)
 >

 It's read as a JSON file, which we could in theory generate, but TBH, i
 think we generate too much already :p

 > How about moving the following into send_notify() ?
 >
 > {{{
 > +            if not zone_class:
 > +                zone_class = str(RRClass.IN())
 > }}}
 >

 We could do that, but we'd still need the string translation to produce
 the correct error up in command_handler(), so it seems a bit superfluous.

 > The rest looks good.

 Thanks, your changes are good to, i'll be merging this shortly

-- 
Ticket URL: <http://bind10.isc.org/ticket/1321#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development