BIND 10 #1747: refactor auth::Query so it's reusable

[BIND 10 Development]

#1747: refactor auth::Query so it's reusable
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  high   |  Sprint-20120320
                  Component:         |            Resolution:
  b10-auth                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  4
Feature Depending on Ticket:  auth   |           Total Hours:  2.66
  performance                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:13 jelte]:

 > crap it, that would almost have been more work than actually doing it :p
 >
 > Ok, added a private class QueryCleaner; which is initialized first thing
 in process(). Removed the other calls to vector::clear() and
 query::reset(). The multi-query tests should already show that this
 cleaner class is used and works (not sure whether it is worth it adding
 other methods to inspect the cleaner object is used).

 Looks okay.  To be perfect I might want to add one test case (in
 addition to checking two successful queries) where an
 exception is actually thrown in process, which shouldn't leave garbage
 in the response to the next query.  But the setup for it may be
 complicated, and it's mostly obvious from the code that it should do
 the cleaning.  So I'm okay with skipping it.  Please merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1747#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development