BIND 10 #1751: stats doesn't separate or consolidate reports from multiple auth instances

[BIND 10 Development]

#1751: stats doesn't separate or consolidate reports from multiple auth instances
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  naokikambe
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120320
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  Core
  statistics                         |  Estimated Difficulty:  6
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => naokikambe


Comment:

 Hello

 Replying to [comment:11 naokikambe]:
 > Actually I'm not sure whether accumulated counts which the non-existent
 instance had should be lost, but I revised the codes so that such
 inconsistency wouldn't happen. Stats queries the pid and instance list to
 Boss, searches the non-existent instance, and then removes statistics data
 which it had. Please review 94f99cad8539239a93877a1774fbadf89238c181.

 I'm not sure if any statistics should be lost after a restart. If the
 xfrin crashes and is started again, it starts its statistics from 0 again.
 But anyway, this is a different issue.

 > > About the code, first I'd like to note that resolver also supports
 multiple instances. Would you add the support to it as well?
 >
 > AFAIK, query counters in the resolver aren't implemented yet.

 Um, yes, that would be good enough reason not to add the support now :-)).

 > Thank you for the suggestion, but I replaced it with the check with a
 real pid.

 That is indeed even better.

 > Yes, I would. Please review eecc0d847fc5f9dc74ce96788e0b3489a98fb244.

 I'm not sure, if the changelog should be so detailed about the
 implementation ‒ after all, it's for users and they don't care if it is by
 using PID or some other magic. How about something like this?:
 {{{
 [bug]           naokikambe
 The statistic counters are now properly accumulated across multiple
 instances
 of b10-auth (if there are multiple instances), instead of providing result
 for
 random instance.
 }}}

 To the new code, I think these list comprehensions are quite hard to read.
 Would it be possible to say the same in some more understandable way, or
 at least add a comment what the meaning of each list is?

 Thank you

 With regards

-- 
Ticket URL: <http://bind10.isc.org/ticket/1751#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development