BIND 10 #1760: implement NSEC3-fetch interface in SQLite3 accessor

[BIND 10 Development]

#1760: implement NSEC3-fetch interface in SQLite3 accessor
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120320
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  NSEC3  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 The code looks ok, and can be merged.

 The finding of the last hash in findPreviousNSEC3Hash could potentially be
 moved into a local function to, make findprevious shorter, but no strong
 opinion there. And maybe it would be a bit cleaner to use a second stmt
 pointer object for the second select (NSEC3_LAST).

 There is one thing I would like to start doing here, but it's not exactly
 in scope. We've been using a pattern in some of the query/renderer reuse
 code; a RAII style cleanup object (in this case, one that would call
 sqlite3_stmt_reset() and sqlite3_clear_bindings() when it is destroyed,
 which would make those intermediate cleanup calls unnecessary (and the
 code more safe in this regard). But since it's not really in scope i think
 that can be deferred.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1760#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development