BIND 10 #963: Utility to upgrade SQLite schema

[BIND 10 Development]

#963: Utility to upgrade SQLite schema
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  stephen
                       Type:         |                Status:  reviewing
  enhancement                        |             Milestone:
                   Priority:         |  Sprint-20120320
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  sqlite schema upgrade              |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jreed):

 Replying to [comment:8 vorner]:

 > Is there any actual reason to implement it in shell? I don't say it is
 wrong, but it is unusual and inconsistent with the rest, so there should
 be a reason for it.


 We do have the zone loader tests written in shell.


 > I don't like this construction with `x`. I don't know where the idiom
 comes from, but in case any of the variables contain spaces, this might
 even be wrong:
 > {{{
 > if [ x$expected_schema = x$actual_schema ]
 > }}}
 >
 > Is there any reason at all not to use the AFAIK more correct and more
 intuitive construct?:
 > {{{
 > if [ "$expected_schema" = "$actual_schema" ]
 > }}}


 Using a character like "x" is very normal (see our autoconf generated
 configure script for many examples).  Some old shells and some /bin/[
 implementations don't work correctly if the quoted content is empty (maybe
 complain about expected argument missing). I don't think any of our build
 systems have this problem though.


 > Also, these tests don't check separate functions (well, they hardly can
 from shell), so they should be considered system-level tests, not unit
 tests. I believe they should be moved there, then.


 Moved to where?

-- 
Ticket URL: <http://bind10.isc.org/ticket/963#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development