BIND 10 #1688: duplicate RR suprression in auth::Query

[BIND 10 Development]

#1688: duplicate RR suprression in auth::Query
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120320
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jinmei
 * milestone:  Sprint-20120403 => Sprint-20120320


Comment:

 > Is it really a better choice to use a std::set? While it'd be more
 efficient for the search itself, it needs to allocate new resource every
 time we insert an entry (and we need to release the resource on
 destruction).
 That's a fair point.  I've altered the RRsetInserter code to use a (pre-
 allocated) vector instead of a set and this is searched sequentially (so
 O(n^2^) comparisons).  To avoid constant construction and destruction,
 that is a member of the Query class and is reset prior to each query.
 This change addresses all the other points.

 If all is OK can you please merge it, or put is back to !UnAssigned as I
 won't be around for the next week and a half.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1688#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development