BIND 10 #1727: IntervalTimerTest.invalidArgumentToIntervalTimer failure

BIND 10 Development do-not-reply at isc.org
Wed Mar 21 19:04:29 UTC 2012


#1727: IntervalTimerTest.invalidArgumentToIntervalTimer failure
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  jinmei
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120403
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  7
            Defect Severity:  N/A    |           Total Hours:  0.42
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:9 vorner]:

 > Both the explanation and the code makes sense. I can't test it directly,
 but I believe you did, so I think this can be merged.

 Thanks for the review, merged, and closing.

 > But I could have a nasty comment on how complicated the stuff with
 preprocessor and several headers might get :-P.

 (If I understand this correctly) yeah I know, but basically it's not
 the problem inside our code, so as long as we use these external
 libraries we need some kind of hack.  A bit more seriously, one
 possible lesson we can learn from this is that it's generally better
 to limit the direct reference to external definitions to a narrower
 places.  Especially for things like Boost or ASIO, where many things
 are defined in header files can be easily accidentally instantiated,
 it's safer to hide them within the places exactly where they are needed.
 (This is one background reason for having the asiolink wrapper layer).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1727#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list