BIND 10 #1443: allow bind10 to run even if configuration is corrupted

[BIND 10 Development]

#1443: allow bind10 to run even if configuration is corrupted
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  muks
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120403
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  configuration                      |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by muks):

 Hi jelte

 My comments:

 {{{
 diff --git a/src/bin/bind10/bind10_src.py.in
 b/src/bin/bind10/bind10_src.py.in
 +        if self.clear_config is not None:
 +            args.append("--clear-config")
 }}}

 That should just check `if self.clear_config:` as it's boolean. I believe
 a check for not None will always be true here. I'm no Python guru, so
 please check this. :)

 {{{
 +                      help="Back up the configuration file and start with
 a clean one")
 }}}

 I think "backup" should be used as a single word here.

 {{{
 diff --git a/src/bin/cfgmgr/tests/b10-cfgmgr_test.py.in
 b/src/bin/cfgmgr/tests/b10-cfgmgr_test.py.in
  class MyConfigManager:
 -    def __init__(self, path, filename):
 +    def __init__(self, path, filename, session=None,
 rename_config_file=None):
          self._path = path
 }}}

 Here too, the default value should be `rename_config_file=False` (though
 it's not used here).

 It probably also needs a ChangeLog entry.

 Please pass it back to me when you have/won't fix these, and I'll review
 it again. :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1443#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development