BIND 10 #1775: update in-memory getAdditional() to handle wildcard match for additional names
BIND 10 Development
do-not-reply at isc.org
Thu Mar 22 23:51:50 UTC 2012
#1775: update in-memory getAdditional() to handle wildcard match for additional
names
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: high | Sprint-20120403
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5
Feature Depending on Ticket: auth | Total Hours: 0
performance |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:10 vorner]:
> > I'm not sure if I understand the concern, but I tried to add some more
> > explanations at d3e876a. Does that address it?
>
> More or less. I was worried that someone could create queries where each
one would add a new name to the tree, which would make it eat all memory.
However, this can't happen since the name must be as the RData in some
other thing in the zone. This is easier to follow from this description
than before.
Ah, okay, then I misunderstood you, but in any event that doesn't
happen. As you probably now understand, the auxiliary tree is fixed
at the time of initial loading (maintaining it with dynamic update is
an issue, but by that time we'll have to fundamentally revisit the
structure anyway).
> > If the latest branch addresses the comments, I think I've addressed
> > all points so far. But I plan to add some more things after that, so
> > regardless of whether they are okay, I'll still continue to work on
> > this ticket (but it'd be nice if you could confirm the updates so
far).
>
> I think they are OK.
Okay, good.
I've updated the branch for addressing a couple of more corner cases
(and that's all I intended to make). Unfortunately, it made the
implementation a bit more complicated than I originally expected, but
I believe the changes are not too big to read.
The commit logs and additional tests should clarify the motivation of
the changes.
--
Ticket URL: <http://bind10.isc.org/ticket/1775#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list