BIND 10 #1752: Measure performance hit of per-message filtering

[BIND 10 Development]

#1752: Measure performance hit of per-message filtering
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120403
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:4 vorner]:
 > Since the branch is not meant for merging, it is kind of messy and
 destructive to the rest of the code, as it is not interesting.

 So I only gave a quick sanity check on it, not a fully detailed
 review.  I have one comment: maybe we want to try something like this
 in checkEnabled:

 {{{#!c++
         if (overrides_.empty() || overrides_.find(id) != overrides_.end())
 {
             return (logger_.isEnabledFor(level));
         } else {
             return (true);
         }
 }}}

 The rationale is that the map would be expected to be empty most of
 the time, and since empty() would still be a bit cheaper than find()
 on an empty map.  Also, we might rather use the map as a "set", i.e.,
 consider any entry as a "true" item.

 This indeed made it a bit faster (although less than 1%) for the empty
 map case on my machine.

 I have no other comment.  I think you can close this ticket and bring
 it to the list.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1752#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development