BIND 10 #963: Utility to upgrade SQLite schema

BIND 10 Development do-not-reply at isc.org
Mon Mar 26 12:15:02 UTC 2012


#963: Utility to upgrade SQLite schema
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  jelte
                       Type:         |                Status:  reviewing
  enhancement                        |             Milestone:
                   Priority:         |  Sprint-20120403
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  sqlite schema upgrade              |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 Replying to [comment:18 jelte]:
 > - I've replaced the direct system.exit values, and change --check to
 return 1 on 'need-update', 2 on 'version too high for me', and higher for
 other errors

 Thats nice. However, I have two notes about this change:
  * „Any higher value indicates a read or command-line error.“ ‒ how is any
 other error signalled? ;-)
  * Related to this, what if anything throws an exception which is not
 caught? Like messed up import.

 > - added 'to stdout' in the manpage verbose description

 Is it true that it's to stdout with the logging?

 > And some other comments based on the discussion above:
 > - I think we can get away with not using the configuration db file name
 for now; I think that if 324 (or any detection of out-of-date schema)
 prints 'please run b10-dbutil --upgrade <database file>, it's good enough
 for the near future

 I believe so, let's create a ticket for it.

 > did i miss anything else?

 Support for multiple database files on input? Or should we put it to
 another ticket?

 Also:
  * DBUTIL_DATABASE_MAY_BE_CORRUPTED ‒ Is the correct word corrupted or
 corrupt? And would it be possible to output the filename of the original
 and backup db?
  * What is the difference between DBUTIL_COMMAND_NONE and
 DBUTIL_NO_ACTION_SPECIFIED? Why do we have both?
  * `grep dbutil` (in the tests) ‒ should it be grep DBUTIL? Or, better,
 grep .?

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/963#comment:19>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list