BIND 10 #1626: Error: Unable to parse response from Auth: Expecting , delimiter: line 1 column 87 (char 87)

BIND 10 Development do-not-reply at isc.org
Thu Mar 29 20:52:41 UTC 2012


#1626: Error: Unable to parse response from Auth: Expecting , delimiter: line 1
column 87 (char 87)
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  jelte
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120403
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  2
            Defect Severity:         |           Total Hours:  0
  Medium                             |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  UnAssigned => jelte


Comment:

 My review:

 {{{
 +        if (c == '\\') {
 +            // next char must be either another \ or "
 +            // see the spec for allowed escape characters
 +            if (strchr("\"\\/\b\f\n\r\t", in.peek()) != NULL) {
 }}}

 Shouldn't that be "\"\\/bfnrt"? Also, it seems they should be decoded into
 the correct escape characters here (\b, \f, \n, \r and \t).

 You should also add testcases for this, or am I missing them from some
 previous commits? :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1626#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list