BIND 10 #1892: Check mode of logger

[BIND 10 Development]

#1892: Check mode of logger
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120501
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => UnAssigned
 * status:  assigned => reviewing


Comment:

 Up for review.

 Note that make check at toplevel will fail when --enable-logger-checks is
 used, due to various issues all around the codebase. The fix in this bug
 catches those problems.

 We discussed this on Jabber:
 {{{
 (2012-05-01 16:04:37) muks: there are log messages like this:
 (2012-05-01 16:04:43) muks: % DATASRC_DATABASE_WILDCARD_MATCH search in
 datasource %1 resulted in wildcard match at %5 with RRset %6
 (2012-05-01 16:05:21) muks: logged by a helper function that takes %1, %2,
 %3, %4, %5, %6
 (2012-05-01 16:05:31) vorner: Yes, that one is a problem
 (2012-05-01 16:05:40) vorner: but I think there'll be more that are
 different than this one
 (2012-05-01 16:06:10) muks: the code that calls the helper function passes
 the DATASRC_DATABASE_WILDCARD_MATCH which only logs what it wants to use
 (2012-05-01 16:06:21) muks: i suppose we can accomodate this?
 (2012-05-01 16:06:34) muks: by only checking if there are args left at the
 end?
 (2012-05-01 16:06:56) muks: i.e., there's %6 left and we don't call .arg()
 for that
 (2012-05-01 16:06:58) vorner: muks: I think the check should be strict and
 used only to check when producing new code, not run by users.
 (2012-05-01 16:07:11) vorner: I want to have the other option checked as
 well
 (2012-05-01 16:07:20) muks: vorner: right now it's disabled by default
 (2012-05-01 16:07:31) vorner: anyway, we might want to get rid of the
 helper in long term
 (2012-05-01 16:07:31) muks: but if we use --enable-option, make check will
 fail for these caes
 (2012-05-01 16:07:32) muks: cases
 (2012-05-01 16:07:43) vorner: yes, that's OK for now I think
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1892#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development