BIND 10 #1878: lettuce tests should be more fail safe about runtime environment

BIND 10 Development do-not-reply at isc.org
Wed May 2 04:49:53 UTC 2012


#1878: lettuce tests should be more fail safe about runtime environment
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120515
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  build  |           Sub-Project:  Core
  system                             |  Estimated Difficulty:  4
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jelte


Comment:

 The solution looks OK, but I'd advise a small change: Move the check
 whether LETTUCE_SETUP_COMPLETED is set from terrain.py to run_lettuce.sh
 (after ./setup_intree_bind10.sh is sourced). This makes vanilla lettuce
 invocations work too. With the code in the branch, it'll only work if run
 through run_lettuce.sh.

 As this is a matter of preference, you can merge the branch if you don't
 want this. It looks good otherwise.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1878#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list