BIND 10 #1892: Check mode of logger

[BIND 10 Development]

#1892: Check mode of logger
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  vorner                             |                Status:  closed
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120515
  medium                             |            Resolution:  fixed
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0.67
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Added a hotfix patch to address this issue:
 {{{
 --- a/src/lib/log/log_formatter.cc
 +++ b/src/lib/log/log_formatter.cc
 @@ -37,7 +37,7 @@ replacePlaceholder(string* message, const string& arg,
      else {
          // We're missing the placeholder, so throw an exception
          isc_throw(MismatchedPlaceholders,
 -                 "Missing logger placeholder in message: " << message);
 +                 "Missing logger placeholder in message: " << *message);
      }
  #else
      else {
 @@ -56,7 +56,7 @@ checkExcessPlaceholders(string* message, unsigned int
 placeholder)
      if (pos != string::npos) {
          // Excess placeholders were found, so throw an exception
          isc_throw(MismatchedPlaceholders,
 -                 "Excess logger placeholders still exist in message: " <<
 message);
 +                 "Excess logger placeholders still exist in message: " <<
 *message);
      }
  #endif /* ENABLE_LOGGER_CHECKS */
  }
 }}}

 As this is a trivial patch, I'm just pushing it to master:

 {{{
 * 1c88a49 [1892] Fix the message string in MismatchedPlaceholders
 exceptions
 }}}

 Resolving the bug as fixed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1892#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development