BIND 10 #1966: logger formatter does too much in the destructor

[BIND 10 Development]

#1966: logger formatter does too much in the destructor
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:
  jinmei                             |                Status:  new
                       Type:         |             Milestone:  Next-Sprint-
  defect                             |  Proposed
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  Core
  logging                            |  Estimated Difficulty:  0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by vorner):

 This will require both less convenient use and expensive change of all our
 logging code. And I don't see the benefit.

 Generally, throwing from destructor can cause trouble. But it's because
 C++
 doesn't really handle the case when two exceptions are being thrown at
 once
 (because there are problems with explicit memory deallocation and
 generally
 exceptions and explicit deallocation cause trouble). But I don't think
 there
 can be two exceptions at once in this case.

 I believe this change is not worth the cost of inconvenience and change
 itself.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1966#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development