BIND 10 #1805: implement getClosestNSEC() within InMemoryZoneFinder
BIND 10 Development
do-not-reply at isc.org
Wed May 9 21:00:33 UTC 2012
#1805: implement getClosestNSEC() within InMemoryZoneFinder
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20120515
medium | Resolution:
Component: data | Sensitive: 0
source | Sub-Project: DNS
Keywords: | Estimated Difficulty: 4
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: in- |
memory NSEC |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:10 jelte]:
>
> The code looks OK.
>
> One documentation nit; the description itself is good, but I'd like to
see at least a reference to what node_path is in findNode's comments. And
perhaps also a little note or ref at the declaration of node_path in
find() and addAdditional().
Thanks for the prompt review. I was not really sure specifically what
kind of additional comments you wanted (especially for findNode()'s
comment - there are already some, and I was not sure what I should add
to it), but I've revised/added comments somehow. Is that better now?
I've made one other minor change: 32bb3f9. See the commit log for the
rationale.
As for making getClosestNSEC public, you're right. But I see you did
it in #1807, so I didn't touch it (and as far as I can see we don't
need it to be public for #1809).
--
Ticket URL: <http://bind10.isc.org/ticket/1805#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list