BIND 10 #1807: support NSEC for empty non-terminal in in-memory (2/2)
BIND 10 Development
do-not-reply at isc.org
Thu May 10 17:00:11 UTC 2012
#1807: support NSEC for empty non-terminal in in-memory (2/2)
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20120515
medium | Resolution:
Component: data | Sensitive: 0
source | Sub-Project: DNS
Keywords: | Estimated Difficulty: 3
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: in- |
memory NSEC |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
I've fixed one minor typo in a comment line. Otherwise the branch
looks okay.
Replying to [comment:10 jelte]:
> (ps. if we're going to redo masterload in the future, it's probably a
good idea to make sure we can generate test data easily through the lib as
well, the current approach is very fragile. It can probably be done better
right now, but would be much much easier if we used some find of
stringToRRSet() function, without full zone context, so you can make
several apex NSECs, to name something).
I'm not sure in which sense you think it's fragile in this context, but
in any case I agree we need something like `stringToRRset()` in the
public API, not as a test utility. (I also agree the current way of
preparing RRsets for tests isn't very clean and is difficult to
use/read, whatever "fragile" means).
--
Ticket URL: <http://bind10.isc.org/ticket/1807#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list