BIND 10 #1967: dhcp6 Solicit_basic test fails

BIND 10 Development do-not-reply at isc.org
Mon May 14 11:26:19 UTC 2012


#1967: dhcp6 Solicit_basic test fails
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  tomek
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  defect                             |  DHCP-20120514
                   Priority:  very   |            Resolution:
  high                               |             Sensitive:  0
                  Component:  dhcp6  |           Sub-Project:  DHCP
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  UnAssigned => tomek


Comment:

 Reviewed commit 7df26862869e043efe8b320d9b0404410f123db0.

 Test works, this has fixed the problem.  However, suggest that rather
 than:
 {{{
     case DUID_LL: {
         // not supported yet
         cout << "Test not implemented for DUID-LL yet." << endl;
     }
     case DUID_UUID: // not supported yet
     default:
         cout << "Not supported duid type=" << duid_type << endl;
         ADD_FAILURE();
 }}}
 ... combine the output via "cout" with the "ADD_FAILURE()" and "FAIL()"
 macros, and make a distinction between the known and unknown DUID types,
 i.e.
 {{{
     case DUID_LL: // not supported yet
         ADD_FAILURE() << "Test not implemented for DUID-LL yet" << endl;
         break;

     case DUID_UUID: // not supported yet
         ADD_FAILURE() << "Test not implemented for DUID-UUID yet" << endl;
         break;

     default:
         FAIL() << "Not supported: DUID type = " << duid_type << endl;
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1967#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list