BIND 10 #1281: dhcp6 tests made distcheck (with gtest) fail (+ interfaces.txt removal) (was: dhcp6 tests made distcheck (with gtest) fail)

[BIND 10 Development]

#1281: dhcp6 tests made distcheck (with gtest) fail (+ interfaces.txt removal)
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  tomek
  jinmei                             |                Status:  accepted
                       Type:         |             Milestone:  Sprint-
  defect                             |  DHCP-20120528
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  dhcp   |           Sub-Project:  DHCP
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Old description:

> We recently enabled gtest (when possible) in 'make distcheck'.
> It failed due to a leftover temporary file (interfaces.txt) created
> in dhcp6/tests.
>
> I've developed a quick hack fix (commit d119c31) to that and pushed it
> in order to keep the buildbot silent, but we need a cleaner fix.
>
> - First, maybe we probably don't want to create it directly under the
> "tests" directory.  Our usual convention is to use a separate directory,
> often named "testdata".
> - Second, though not directly related to this problem, dhcp6's
> Makefile.am
>   seems to have a full of naive copy-paste.  For example, I suspect
>   we don't need this:
> {{{
> AM_CPPFLAGS +=
> -DTEST_DATA_DIR=\"$(abs_top_srcdir)/src/lib/testutils/testdata\"
> }}}
>   LIBRARY_PATH_PLACEHOLDER shouldn't be necessary either - it's only
>   for python scripts.
>
> I tentatively give this ticket to tomek so that it won't be buried.
> Feel free to change it to be unassigned, etc.

New description:

 We recently enabled gtest (when possible) in 'make distcheck'.
 It failed due to a leftover temporary file (interfaces.txt) created
 in dhcp6/tests.

 I've developed a quick hack fix (commit d119c31) to that and pushed it
 in order to keep the buildbot silent, but we need a cleaner fix.

 - First, maybe we probably don't want to create it directly under the
 "tests" directory.  Our usual convention is to use a separate directory,
 often named "testdata".
 - Second, though not directly related to this problem, dhcp6's Makefile.am
   seems to have a full of naive copy-paste.  For example, I suspect
   we don't need this:
 {{{
 AM_CPPFLAGS +=
 -DTEST_DATA_DIR=\"$(abs_top_srcdir)/src/lib/testutils/testdata\"
 }}}
   LIBRARY_PATH_PLACEHOLDER shouldn't be necessary either - it's only
   for python scripts.

 I tentatively give this ticket to tomek so that it won't be buried.
 Feel free to change it to be unassigned, etc.

 Update: [tomek] as a general clean-up this ticket also contains
 interfaces.txt removal.

--

Comment (by tomek):

 Location of interfaces.txt file is somewhat tricky. This mechanism was a
 stub that was used before interface detection was implemented (now working
 on Linux). I had a discussion with Stephen and we decided that there is no
 benefit in trying to make it work on systems that we really don't care
 about and it just makes our life more difficult (on Linux and other OSes).
 So we decided to remove support for interfaces.txt.

 It is true that makefiles (especially the ones in src/bin/dhcp6) contain
 many copy-and-paste errors. These were my first contributions to BIND10
 project, so I didn't understand what is really needed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1281#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development