BIND 10 #1890: CFGMGR_RENAMED_CONFIG_FILE misleading

BIND 10 Development do-not-reply at isc.org
Fri May 18 05:14:28 UTC 2012


#1890: CFGMGR_RENAMED_CONFIG_FILE misleading
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  jreed
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120529
  medium                             |            Resolution:
                  Component:  Boss   |             Sensitive:  0
  of BIND                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  2
            Defect Severity:  Low    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jreed
 * status:  assigned => reviewing


Comment:

 Hi Jeremy

 Replying to [ticket:1890 jreed]:
 > Maybe the message should not say ", will create new %1". (It does not
 exist until something later creates it.)

 This message seems to be correct. It exactly says what it does. Do you
 want it to say "..., will create new %1 when necessary." ? It can be added
 to clarify what happens.

 > And it didn't really rename it.  Maybe just say that the clear-config
 happened:  The %1 configuration was removed, a backup was placed at %2.

 If it didn't, that would be a bug. In #1443, Jelte did add testcases that
 verifed that the file had been moved correctly. It should rename the file
 printed in the log message to the .bak backup.

 Do you intend to say that a new file with the name is created, so it does
 not appear as a rename? Even in this case, the log message seems fine as
 it says a new file will be created in its place.

 >
 > Also this should not be a INFO, but should be more noticeable like a
 WARN.

 WARN is for warning the user about problems or potential problems, whereas
 the config file is renamed due to a switch invoked by the user. INFO is
 fine for this I think.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1890#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list