BIND 10 #1207: Enable the data source factory
BIND 10 Development
do-not-reply at isc.org
Fri May 18 16:56:08 UTC 2012
#1207: Enable the data source factory
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
stephen | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20120529
medium | Resolution:
Component: data | Sensitive: 0
source | Sub-Project: DNS
Keywords: | Estimated Difficulty: 5
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:17 jelte]:
Looks okay, with one minor point. At this stage I'd remove this
comment:
{{{#!cpp
// This test uses dynamic load of a data source module, and won't work
when
// statically linked.
TEST_F(AuthCommandTest,
#ifdef USE_STATIC_LINK
DISABLED_loadZoneSQLite3
}}}
because now we have many these tricks, and this one is not even the
first one of this .cc. The intent of USE_STATIC_LINK is described in
Makefile.am, so if someone wonders that should be sufficient (and if
it's not sufficient, it'd also not make sense to just comment about it
for this particular test).
I don't think we need another review cycle for this. With cleaning it
up please merge.
--
Ticket URL: <http://bind10.isc.org/ticket/1207#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list