BIND 10 #1704: log output mixed

[BIND 10 Development]

#1704: log output mixed
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  muks
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120529
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  15
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:39 stephen]:

 > >> Not looking into it closely, but we should probably move this stuff
 to !LoggerImpl.
 > I concur.  The logger is written using a pimpl idiom, and most of the
 logger code is in !LoggerImpl.
 >
 > >> On a related note, isn't there a better primitive than the very low
 level system call? From a quick look boost also has a similar (in addition
 to interprocess_mutex) API: file_lock.
 > > After using interprocess_mutex and reverting it, I side with fcntl()
 for this case. Its use here is very straightforward and any UNIX
 programmer can follow it. The behaviour is well defined (multiple locks
 are OK, and when process terminates, the locks are removed automatically).
 > Looking at the boost::file_lock documentation, I strongly suspect that
 this is a layer on top of fcntl.

 I suspected that, too, but
 - it implements RAII in it, so we don't have to do anything to make it
   exception safe ourselves.
 - if should be more portable than the direct use of a system call.
   especially so if and when we consider supporting Windows.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1704#comment:40>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development