BIND 10 #1207: Enable the data source factory

[BIND 10 Development]

#1207: Enable the data source factory
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  stephen                            |                Status:  closed
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120529
  medium                             |            Resolution:  complete
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  11.1
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * status:  reviewing => closed
 * resolution:   => complete


Comment:

 Replying to [comment:18 jinmei]:
 > Replying to [comment:17 jelte]:
 >
 > Looks okay, with one minor point.  At this stage I'd remove this
 > comment:
 >

 Ack, removed.

 >
 > I don't think we need another review cycle for this.  With cleaning it
 > up please merge.

 I did one final change; the test bots caught a distcheck error, due to the
 added updateConfig it created a default sqlite3 database file, which
 didn't get cleaned up, so I set the 'basic sqlite3 backend' to use the
 database file as well:
 {{{
 diff --git a/src/bin/auth/tests/command_unittest.cc
 b/src/bin/auth/tests/command
 index d93adb5..31962e6 100644
 --- a/src/bin/auth/tests/command_unittest.cc
 +++ b/src/bin/auth/tests/command_unittest.cc
 @@ -297,7 +297,9 @@ TEST_F(AuthCommandTest,
                                "      }"
                                "    ]"
                                "  }"
 -                              "]}"));
 +                              "],"
 +                              " \"database_file\": \"" + test_db + "\""
 +                              "}"));
      module_session.setLocalConfig(map);
      server_.setConfigSession(&module_session);
 }}}

 I'm assuming this change is basic enough not to need another round either,
 so I've merged it.

 Thanks for the extensive review, closing ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1207#comment:21>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development