BIND 10 #1954: Implement perfdhcp command parser

[BIND 10 Development]

#1954: Implement perfdhcp command parser
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  enhancement                        |  DHCP-20120528
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DHCP
  perfdhcp                           |  Estimated Difficulty:  16
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  6      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by marcin):

 * hours:  36 => 6
 * estimatedhours:  0 => 16
 * owner:  marcin => stephen


Comment:

 Thanks for thorough code review. I updated code accordingly.

 A couple of answers:
 ''version(): just a remark that this will need to be changed once we've
 sorted out how we are
 going to maintain a version number.''

 Agree


 ''Test Base: if the vector::operator==() fails on FreeBSD, does
 std::equal() work? In other words, does
 EXPECT_TRUE(std::equal(v1.begin(), v1.end(), mac));
 ... work?
 ''
 Yes, I corrected this in the test.


 ''Tests ReportDelay/RandomRange/LocalPort/Preload/Seed: should also check
 for invalid values of the argument''

 Number of new negative test cases added

-- 
Ticket URL: <http://bind10.isc.org/ticket/1954#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development