BIND 10 #1944: Fix all broken logger format strings

BIND 10 Development do-not-reply at isc.org
Fri May 25 11:43:50 UTC 2012


#1944: Fix all broken logger format strings
-------------------------------------+-------------------------------------
                   Reporter:  muks   |                 Owner:  UnAssigned
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120529
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  7
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => UnAssigned
 * status:  accepted => reviewing


Comment:

 Hello

 The branch is ready for review. But here's the catch:
  * I introduced few tweaks to the strict checking and logging as a whole,
 to produce less false positives and produce better error messages.
  * The last commit (00472db8fd05a7837e468e9354710cc8be7d0534) on the
 branch should not go to master and I'll merge the one before that. This
 one disables some logging completely. This is the infamous function in the
 database back-end which does some aggregated logging and passes more
 information to the log system, than the message has placeholders on
 purpose. This does produce the logger messages with `@@Missing
 placeholder…`, and these are the ones in the example. But as we did not
 reach consensus on this one before, and it would need some more than
 trivial refactoring of the code, I'd like not to solve this one in this
 ticket. Should I bring it to the mailing list and create a ticket for it?

 Except for the false positives created by python exceptions (now
 suppressed) and the one aggregate function, I found one message ID that
 has it wrong and fixed.

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/1944#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list