BIND 10 #1944: Fix all broken logger format strings

BIND 10 Development do-not-reply at isc.org
Tue May 29 06:30:49 UTC 2012


#1944: Fix all broken logger format strings
-------------------------------------+-------------------------------------
                   Reporter:  muks   |                 Owner:  vorner
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120529
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  7
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => vorner


Comment:

 * The code changes look fine.

 * `make check` fails inside `src/lib/python/isc/ddns/` but it looks like
   the failure is unrelated.

 * This ticket was created separately so that we can start using
   `--enable-logger-checks` on our build machines once it was fixed.
   I think `logAndCreateResult()` has to be fixed in this bug too.
   (I gave it 10 points in my estimation.)

 * Lettuce also runs fine, so this ticket is otherwise done.

 Regarding `logAndCreateResult()`, can it not be easily fixed by adding
 new message ids, and replacing the `logAndCreateResult()` call with the
 appropriate `LOG_XXXX()` call + `return (ResultContext()) ? There seem
 to be 5 such calls. Understanding what needs to be logged in each place
 can take time though.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1944#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list