BIND 10 #1993: simple style checker

BIND 10 Development do-not-reply at isc.org
Tue May 29 07:57:01 UTC 2012


#1993: simple style checker
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:
  jinmei                             |                Status:  new
                       Type:  task   |             Milestone:  Next-Sprint-
                   Priority:         |  Proposed
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by vorner):

 Hello

 Replying to [comment:3 jinmei]:
 > > Or, could we try to reuse the hook which was in the svn?
 >
 > For that purpose I'm afraid the checker needs to be false-positive
 > free, and it will make the task too big, if not impossible.  What I
 > thought is something closer to quick hack, allowing some level of
 > false positive (as long as they are not too noisy), and just helping
 > reduce discussing trivials in code review.

 I meant the code of the hook, because we had a code that did check
 something. I was not really proposing on where to put it.

 But if I would be proposing it, I think it would be nice if the script
 could be made to work as a (local) pre-commit hook in git. This is the
 right place to suggest fixing the commit, not when it is pushed and I
 think these hooks can be „forced“ when they complain. So the false
 positives would be only a minor annoyance.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1993#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list