BIND 10 #1735: ddns_socket file left in build directory

[BIND 10 Development]

#1735: ddns_socket file left in build directory
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  jelte
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  low    |  Sprint-20120612
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:  DDNS   |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jelte


Comment:

 Replying to [comment:8 jelte]:
 > The method you added duplicates an existing one, which should actually
 be called already (clear_socket()).

 Aiieeeee... aiieeeeeeee!

 > Some of the unit tests is mucking with it, and they appear to put it
 back, but only after it would have been called; I suspect that we should
 make them either real proxies (easy way would be to add
 self.!__orig_clear() to !__clear_socket() in ddns_test.py around line 380.
 An alternative would be to explicitly call it in the tearDown() there,
 after it is put back, but I think i personally prefer the former.

 Yes the former approach is good. I've made a fresh branch (trac1735_2) and
 verified that the stale socket file is removed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1735#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development