BIND 10 #2298: Xfrout/zones and XML stats

[BIND 10 Development]

#2298: Xfrout/zones  and XML stats
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  UnAssigned
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20121106
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  statistics                         |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:12 naokikambe]:

 > Thank you for reviewing. But I'm not sure whether you are a real
 reviewer for this ticket. So I left it '!UnAssigned'. If this is wrong,
 please assign yourself.

 I noticed some minor things, but this chunk seems okay.

 The minor comments are:

 - This can be simplified:
 {{{#!python
         keys = list(elem.keys())
         keys.sort()
         for key in keys:
 }}}
   to
 {{{#!python
         for key in sorted(elem.keys()):
 }}}

 - probably not a issue of this branch, but these two cases are bit
   awkward:
 {{{#!python
         # for specifying empty strings in element and identifier
         self.assertEqual([],
                          stats_httpd.item_name_list('', ''))
         # for specifying wrong element, which is an non-empty string,
         # and an non-empty string in identifier
         self.assertRaises(isc.cc.data.DataTypeError,
                          stats_httpd.item_name_list, 'a', 'a')
 }}}
   because the first parameter it not a dict but it somehow succeeds.

 - related to the previous point:

 > > - is it okay not to consider the case where ident is empty here?
 > > {{{#!python
 > >             idstr = '%s[%s]' % (ident, i)
 > > }}}
   Actually it can happen as in this test:
 {{{#!cpp
         self.assertRaises(isc.cc.data.DataTypeError,
                          stats_httpd.item_name_list, [1,2,3], '')
 }}}
   and how it fails is not so trivial.  It fails in the recursive call
   to item_name_list() because now the 2nd parameter to find() is not
   empty.  I don't know if this means we need to do something in this
   branch, though.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2298#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development