BIND 10 #2422: log4cplus threading issues: not logging at all from a new thread

[BIND 10 Development]

#2422: log4cplus threading issues: not logging at all from a new thread
-------------------------------------+-------------------------------------
            Reporter:  jelte         |                        Owner:
                Type:  defect        |                       Status:  new
            Priority:  medium        |                    Milestone:
           Component:  logging       |  Sprint-20121106
           Sensitive:  0             |                     Keywords:
         Sub-Project:  DNS           |              Defect Severity:  N/A
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  4
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 We have run into a few logging+threads issues over the past few days, one
 of them is that LOG_XXX calls do not do anything at all on some systems
 (e.g.
 http://git.bind10.isc.org/~tester/builder/BIND10-lettuce/20121101112722-MacOS/logs/lettuce.out
 the test fails because the load-success line is never logged. The code
 does it succesfully, and calls the LOG_DEBUG macro, but nothing happens).

 This is with log4cplus 1.0.4 without any special configure options, as far
 as I know. The problem may very well be that logger objects are not
 thread-safe, and/or a different bug in log4cplus; or maybe we shouldn't
 share logger instances over threads in the first place.

 The latter does appear to help; creating a separate isc::log::Logger
 instance specific for the thread makes it work as expected.

 Attaching a patch that does that.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2422>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development