BIND 10 #2371: define dns::MasterLexer class

BIND 10 Development do-not-reply at isc.org
Fri Nov 2 21:50:14 UTC 2012


#2371: define dns::MasterLexer class
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121106
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  loadzone-ng                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:12 muks]:

 > The rest look fine. You can do the `open()`/`close()` rename and
 directly merge it to master.

 Thanks, but I actually wanted to make one final change based on the
 latest update of #2369: handling the case where opening a source file
 fails.

 To do so, I first merged the latest snapshot of trac2369.  There was
 no conflict, so you can ignore the merge commit.  I made updates
 on top of it (starting from 5654a07), which I'd like you to review.

 First, d0a51e7 is a kind of regression fix in 2369.

 I made the method name change in b2fe684 and f15deef.

 And, finally, I changed the interface of pushSource(filename) so it
 catches the exception and returns according results (commit 7a72794).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2371#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list