BIND 10 #2369: InputSource helper class for MasterLexer

[BIND 10 Development]

#2369: InputSource helper class for MasterLexer
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121106
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  loadzone-ng                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => vorner


Comment:

 Hi Michal

 Replying to [comment:22 vorner]:
 > Could you, at least, add a TODO note to the saveLine and compact methods
 to
 > check if they are needed an possibly make them private?

 Done. :)

 > With the copyability, I think jinmei mentioned in one of the comments
 here that
 > it's no longer needed to be copyable.

 Made non-copyable now. :)

 > Yes, you can add the explicit keywords to the constructors, though I
 don't
 > think this could ever surprise us (passing an ifstream instead of
 InputSource
 > and auto-creating one for us probably won't be a huge problem).

 They are now `explicit`.

 I appreciate that both of you are taking an interest and reviewing this
 bug. :) I've tried to separately quote and reply to both sets of comments.
 But due to the length of the thread, it may be that certain things get
 missed:

 * What to do with prefix and suffix increment/decrement operators (what
 style to use from [[CodingGuidelines]])?
 * How to test a `ReadError` exception (for this I don't have a surefire
 way yet).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2369#comment:26>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development