BIND 10 #2369: InputSource helper class for MasterLexer

[BIND 10 Development]

#2369: InputSource helper class for MasterLexer
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  closed
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121120
  medium                             |            Resolution:  fixed
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  3.72
Feature Depending on Ticket:         |
  loadzone-ng                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Merged to `master` branch in commit
 `560a71919bda37ad20e54efed07183acc5413a8a`:
 {{{
 * dce5a55 [2369] Use prefix syntax for increment/decrement operators
 * 24862b6 [2369] Make InputSource non-copyable
 * 31745f2 [2369] Add TODOs to remove saveLine() and compact() later
 * ff7cec4 [2369] Describe why the operation failed in OpenError exception
 * 265fb98 [2369] Make constructors explicit
 * 9af419d [2369] Add InputSource::mark() as a combination of saveLine()
 and compact()
 * ccb0973 [2369] Constify variables in various places
 * 4d7d678 [2369] Read data from the test file to check the InputSource
 * ed1a2ad [2369] Use the more specialized std::ifstream instead of
 std::fstream
 * 9f52320 [2369] Rename non-existent filename in test
 * 80b227a [2369] Move exceptions to the top of class
 * a2090f1 [2369] Throw OpenError when opening the input file fails
 * f142087 [2369] Add a file test as well
 * e32617d [2369] Explain how compact() affects ungetAll()
 * eb92bed [2369] Distinguish between EOF and failures in getChar()
 * 5ac6e8b [2369] Use a const variable's value for END_OF_STREAM state
 * 710bac3 [2369] Initialize buffer_pos_ with 0
 * b27d601 [2369] Constify name_
 * 6b8bf7d [2369] Rename exception to UngetBeforeBeginning
 * 6847454 [2369] Rename files to master_lexer_inputsource.{cc,h}
 * 0dd898f [2369] Use createSreamName() from #2371 instead of using
 sprintf()
 * ba71154 [2369] Fix vector::erase() call in InputSource
 * 51e26dc [2369] Add InputSource::compact() method
 * 9843e33 [2369] Add API documentation for InputSource
 * b5ca6ac [2369] Make InputSource manage opening files internally
 * 2c8d3ac [2369] Check saveLine() + ungetAll()
 * a6093a8 [2369] Throw a custom exception in ungetChar()
 * cb9e761 [2369] Update comment, whitespace
 * 7fb9113 [2369] Check as much as possible that line numbers are
 decremented correctly
 * 8aa5e22 [2369] Fix test, skipping backwards before doing newline check
 * 29ff6be [2369] Add InputSource helper class (work-in-progress)
 }}}

 Resolving as fixed. Thank you for the reviews Michal and Jinmei.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2369#comment:30>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development