BIND 10 #2342: MySQL IPv6 lease database access functions
BIND 10 Development
do-not-reply at isc.org
Fri Nov 9 15:46:56 UTC 2012
#2342: MySQL IPv6 lease database access functions
-------------------------------------+-------------------------------------
Reporter: | Owner: stephen
stephen | Status: reviewing
Type: task | Milestone: Sprint-
Priority: | DHCP-20121115
medium | Resolution:
Component: | Sensitive: 0
dhcpdb | Sub-Project: DHCP
Keywords: | Estimated Difficulty: 0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by marcin):
* owner: marcin => stephen
Comment:
Reviewed commit b0ad16d99eb0bc2148976a31c4dbf7ff0ed5516a
As we discussed on jabber... when I tried multithreaded build I found race
condition occuring between two threads that were creating libdhcp++ and
libdhcp_srv. This is because of the dependency between these libraries
which has been introduced with commit:
{{{
[2342] Add programmer documentation.
}}}
As you suggested I moved the duid{.h, .cc} to libdhcp_srv and removed the
dependency. However once we come up with the permanent solution for the
race conditions we should revert this change.
The #2475 has been submitted to address it.
I fixed some remaining typos in lease_mgr.h and pushed changes.
With respect to complex cast...
Added comments are good but if the performance considerations are your
major motivation not to do ''redundant copy'' it should be included in the
comment too. If you agree, please add extra comment.
--
Ticket URL: <http://bind10.isc.org/ticket/2342#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list