BIND 10 #2157: Create an interface to pass statistics counters in Auth module

[BIND 10 Development]

#2157: Create an interface to pass statistics counters in Auth module
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  y-aharen                           |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20121120
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  b10-auth                           |  Estimated Difficulty:  8
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by y-aharen):

 * owner:  y-aharen => jinmei


Comment:

 Hello,

 I'll leave how to represent RRtype counters open and removed them
 from the branch.

 Replying to [comment:28 jinmei]:
 > Replying to [comment:27 y-aharen]:

 > '''general'''
 >
 > - Isn't it possible to unify the definition of the counter information
 >   (things like QR_REQUEST_IPV4, QR_OPCODE_QUERY, etc), e.g., in some
 >   separate file and auto generate others?  Right now, we have the same
 >   kind of information at least in 3 different places: auth.spec,
 >   statistics_items.h, and the man page.  Even excluding RR types, that
 >   can easily cause maintenance problems.
 Now they are automatically generated in compile time.

 > - I'd like to avoid relying on a magic keyword like `_SERVER_`.  In
 >   fact, there could even a zone of that name.
 The other modules such as Xfrout has same structure. If it's not suitable,
 wiki:StatisticsItems and the other modules should also be updated. I think
 it is out of scope of this ticket, can't it be in the separate one?

 > - if possible I'd like to make one clarification before merging this
 >   branch.  That is, the BIND 9 version of statistics counters are
 >   confusing in that the sum of any of QRYxxx does not match the number
 >   of incoming queries.  I'd clarify the counters so that at least the
 >   sume of some subset of QRYxxx counters equals to QR_OPCODE_QUERY.
 I agree the meaning of the counters are confusing. However, I think some
 of
 BIND 9 users rely on the counters and are not willing to change them.
 I propose to leave them in BIND 10 for compatibility. If you don't like to
 leave them, I'd like to just remove them from the branch and the
 discussion
 for QR_QRYxxx should be in another ticket.

 > '''statistics_items.h'''
 >
 > - We shouldn't use namespace {} or define things here.  Only
 >   declaration is okay.  See #2358 for these.
 OK, definitions are moved into .cc files.

 Spec for per-zone statistics will be considered in the other ticket to
 implement per-zone statistics (planning to work next of this ticket).

 Thanks,

-- 
Ticket URL: <http://bind10.isc.org/ticket/2157#comment:32>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development